From: Kevin Ballard Date: Tue, 28 Sep 2010 00:14:55 GMT Subject: Re: [PATCH] merge-recursive: option to specify rename threshold Message-ID: <7FEED963-13E1-4A77-959A-FFD06669ED13@sb.org> In-Reply-To: <20100928000837.GH11957@burratino> On Sep 27, 2010, at 5:08 PM, Jonathan Nieder wrote: > Kevin Ballard wrote: > >> Good timing, I just sent out a patch that does almost exactly this, >> though I went with --break-rewrites instead of --detect-rewrites. > > Both new patches look good to me, for what it's worth (though it > would be nicer to have tests, of course :)). I considered tests, and I looked at the existing ones. I am unable to find any tests that actually test setting the rename/copy score to anything other than the default, and I was a bit hesitant to add tests that simply checked to make sure the long-form option was parsed correctly, as that would just be duplicating existing tests that use the short-form arguments. -Kevin Ballard