From: Lars Schneider <larsxschneider@gmail.com>
Date: Tue, 11 Oct 2016 15:29:07 GMT
Subject: Re: [PATCH v10 13/14] convert: add filter.<driver>.process option
Message-ID: <7ED32498-0757-4499-93AC-DC9116738799@gmail.com>
In-Reply-To: <a80f6399-b344-b979-d849-1dc7f899fabe@web.de>


> On 09 Oct 2016, at 07:32, Torsten Bögershausen <tboegi@web.de> wrote:
> 
> On 09.10.16 01:06, Jakub Narębski wrote:
>>> +------------------------
>>>> +packet:          git< status=abort
>>>> +packet:          git< 0000
>>>> +------------------------
>>>> +
>>>> +After the filter has processed a blob it is expected to wait for
>>>> +the next "key=value" list containing a command. Git will close
>>>> +the command pipe on exit. The filter is expected to detect EOF
>>>> +and exit gracefully on its own.
>> Any "kill filter" solutions should probably be put here.  I guess
>> that filter exiting means EOF on its standard output when read
>> by Git command, isn't it?
>> 
> Isn't it that Git closes the command pipe, then filter sees EOF on it's stdin
> 
> and does a graceful exit.

Correct!

- Lars