From: Philippe Blain <levraiphilippeblain@gmail.com>
Date: Thu, 30 Jan 2020 13:28:01 GMT
Subject: Re: [PATCH v3 08/12] grep: allow submodule functions to run in parallel
Message-ID: <7DA86BCF-8A20-4B06-BDC0-82EEDFCC0AE5@gmail.com>
In-Reply-To: <CAHd-oW590ZnNnCdD5LLiBQB73LRUVEf41wv7FLJvGMwd2kLYww@mail.gmail.com>

Hi everyone,
>> 
>> @@ -958,6 +946,8 @@ int cmd_grep(int argc, const char **argv, const char *prefix)
>>                        /* die the same way as if we did it at the beginning */
>>                        setup_git_directory();
>>        }
>> +       if (!use_index)
>> +               recurse_submodules = 0; /* ignore */
>> 
>>        /*
>>         * skip a -- separator; we know it cannot be
> 
> Yeah, this seems more meaningful, IMHO, as we can easily see that the
> recurse_submodules option was dropped in favor of using --no-index.
> 
I agree. I’ll send a v2 of my patch with this added.

Philippe.