From: Ben Knoble <ben.knoble@gmail.com>
Date: Tue, 08 Sep 2026 14:59:53 GMT
Subject: Re: [PATCH] advice: use global config for default branch name
Message-ID: <7D54AA3C-0724-4C8A-9CB8-64150CD3A051@gmail.com>
In-Reply-To: <20260908185653.34702-1-ub4nal@mail.ru>


> Le 8 sept. 2026 à 10:43, Vsevolod Myalitsin <ub4nal@mail.ru> a écrit :
> 
> 
> I considered using an "is_global(key)" helper, but I think adding a field to "advice_setting" is cleaner.
> 
> The change is quite small:
> 
> struct advice_setting {
>     const char *key;
> +    int global_hint;
>     enum advice_level level;
> };
> 
> Then the scope is specified directly for the relevant advice:
> 
>    -[ADVICE_DEFAULT_BRANCH_NAME] = { "defaultBranchName" },
>    +[ADVICE_DEFAULT_BRANCH_NAME] = { "defaultBranchName", 1 },
> 
> And used when building the hint:
> 
>     static void vadvise(const char *advice, int display_instructions,
>    -                    const char *key, va_list params)
>    +                    const char *key, int global, va_list params)
>     {
>         ...
> 
>         if (display_instructions)
>    -        strbuf_addf(&buf, turn_off_instructions, key);
>    +        strbuf_addf(&buf, turn_off_instructions,
>    +                    global ? "--global" : "", key);
>     }
> 
> This keeps the information about the intended config scope in "advice_setting", rather than making "vadvise()" depend on specific advice keys.

That also seems good to me. I think I prefer it. 

PS it is normal here to bottom-post and quote at least the
relevant parts of the message to which you reply ;)