From: Karthik Nayak <karthik.188@gmail.com>
Date: Tue, 17 Mar 2015 13:59:40 GMT
Subject: Re: [PATCH v4 1/2] cat-file: teach cat-file a '--literally' option
Message-ID: <7BBE9C66-3654-4E6A-96FB-1EF16FC28E35@gmail.com>
In-Reply-To: <CAPig+cSJVGy_L6mThFCU1Bw0ZrZEv=pZ8=W8gTZd=A5y2fcR7Q@mail.gmail.com>



On March 17, 2015 12:21:33 PM GMT+05:30, Eric Sunshine <sunshine@sunshineco.com> wrote:
>On Tue, Mar 17, 2015 at 1:16 AM, Karthik Nayak <karthik.188@gmail.com>
>wrote:
>> diff --git a/builtin/cat-file.c b/builtin/cat-file.c
>> index df99df4..1625246 100644
>> --- a/builtin/cat-file.c
>> +++ b/builtin/cat-file.c
>> @@ -323,8 +338,8 @@ static int batch_objects(struct batch_options
>*opt)
>>  }
>
>I don't presently have time for a proper read-through, however, this
>popped out while quickly running my eyes over the changes.
>
>>  static const char * const cat_file_usage[] = {
>> -       N_("git cat-file (-t | -s | -e | -p | <type> | --textconv)
><object>"),
>> -       N_("git cat-file (--batch | --batch-check) <
><list-of-objects>"),
>> +       N_("git cat-file (-t [--literally]|-s
>[--literally]|-e|-p|<type>|--textconv) <object>"),
>> +       N_("git cat-file (--batch | --batch-check)
><list-of-objects>"),
>
>The '<' in the second line before <list-of-objects> is intentional. It
>means that <list-of-objects> is provided via stdin. Therefore, it is
>incorrect to remove it.
I see. It seemed out of place. Makes sense, probably should have asked. 

Thanks.
>
>>         NULL
>>  };
>>

-- 
Sent from my Android device with K-9 Mail. Please excuse my brevity.