From: Michael Cohen Date: Mon, 05 Nov 2007 12:09:26 GMT Subject: Re: [RFC PATCH] OSX Mail.app IMAP cache support for git-mailsplit? Message-ID: <7B84FFB7-5FE9-4D24-AEC5-43F667B59876@mac.com> In-Reply-To: On Nov 5, 2007, at 5:39 AM, Johannes Schindelin wrote: > Hi, > > you have a very weird mail setting; I had to add the git list back > to the > Cc. This is just annoying enough for me to write an extra paragraph > to > annoy you back ;-) Have to get used to this; thank you. :) > Several comments (your patch not inlined, since you did not inline it > either): > > - there needs to be a space between the ) and the { in the first if > line. Doh. done. > - you probably forgot to remove the original "if (populate...)...". > That > means that populate would be called _twice_, even if successful. good catch. > - git is written in C. Therefore, "//" as a way to comment out is > wrong. > - if you still return -1 when the dir could not be opened, I wonder > what > the rationale is to comment the error out. More work needs to be done in there and in builtin-mailinfo.c to massage the mail format that Apple is using. Also what I think I need to do there is check the path that is being tested and print something like "%s/cur could not be found, trying alternate path" on the first test? > P.S.: You might want to send patches as these right away, without > asking > if anybody cares (you'll see that very soon), but rather in accord > with > Documentation/SubmittingPatches. Thanks for that.