From: Kevin Ballard <kevin@sb.org>
Date: Thu, 21 Oct 2010 20:28:57 GMT
Subject: Re: [PATCH v2] blame: Add option to show author email instead of name
Message-ID: <79AB0864-E151-468E-9C86-EBCAD929938B@sb.org>
In-Reply-To: <20101021180525.GA11501@burratino>

On Oct 21, 2010, at 11:05 AM, Jonathan Nieder wrote:

> Kevin Ballard wrote:
> 
>> +++ b/t/t8002-blame.sh
>> @@ -6,4 +6,9 @@ test_description='git blame'
>> PROG='git blame -c'
>> . "$TEST_DIRECTORY"/annotate-tests.sh
>> 
>> +PROG='git blame -c -e'
>> +test_expect_success 'Blame --show-email works' '
>> +    check_count "<A@test.git>" 1 "<B@test.git>" 1 "<B1@test.git>" 1 "<B2@test.git>" 1 "<author@example.com>" 1 "<C@test.git>" 1 "<D@test.git>" 1
>> +'
>> +
> 
> Bonus nit: does this belong in annotate-tests.sh or does it only apply
> to "git blame" and not "git annotate"?  If the latter, a note in the
> commit message would be helpful.

--show-email originally only applied to git-blame. I tweaked the patch to make it apply to git-annotate simply because check_count can't handle the format of git-blame, but the intention of the change wasn't to make it apply to git-annotate in the first place. You'll note I also didn't document it in the manpage for git-annotate. If you think it's better to move it into annotate-tests.sh, I can do that, but that does mean officially declaring git-annotate as supporting --show-email.

-Kevin Ballard