From: Stephen Boyd Date: Wed, 03 Jun 2009 19:35:27 GMT Subject: Re: [PATCH] parse-options: make OPT_NUMBER's argh explicit Message-ID: <780e0a6b0906031235q1438b76cyba1172556c94d1d0@mail.gmail.com> In-Reply-To: <4A264DFA.3090309@lsrfire.ath.cx> On Wed, Jun 3, 2009 at 3:18 AM, René Scharfe wrote: > > Nice code reduction.  s/NUMBER/INTEGER/ in the commit message? Oops. Thanks, I'll fix that. > > By the way, can the switch be replaced by a simple check for > PARSE_OPT_NOARG now? > This looks possible. I think just set PARSE_OPT_NOARG as the flag of the appropriate OPT_* macros. I'll have to grep the tree for custom uses of OPTION_* though. Should that be all squashed together? Or maybe that could be a follow up patch?