From: Stephen Boyd <bebarino@gmail.com>
Date: Thu, 21 May 2009 19:03:23 GMT
Subject: Re: [PATCHv2 1/2] parse-options: add PARSE_OPT_LITERAL_ARGHELP for complicated argh's
Message-ID: <780e0a6b0905211203g3223fe3fp5eed27ebf244394a@mail.gmail.com>
In-Reply-To: <4A1586A7.9000909@lsrfire.ath.cx>

On Thu, May 21, 2009 at 9:51 AM, René Scharfe
<rene.scharfe@lsrfire.ath.cx> wrote:
> Junio C Hamano schrieb:
>> Hmmm, why does this break t0040 (I am queuing this on top of 5acb3e5)?
>
> Probably because it changes this:
>
>        pos += fprintf(...);
>
> into this (simplified, usage_argh() expanded):
>
>        pos += pos + fprintf(...);
>
> usage_argh() doesn't need the parameter pos.
>
> René
>

Woops. I thought I ran the tests but I guess I didn't. This is the
correct fix, thanks.