From: Stephen Boyd <bebarino@gmail.com>
Date: Mon, 04 May 2009 18:39:53 GMT
Subject: Re: [PATCH v2 2/4] Add format.coverauto boolean
Message-ID: <780e0a6b0905041139x3a764768ocbbd8d9353ea568f@mail.gmail.com>
In-Reply-To: <1241431142-8444-3-git-send-email-ft@bewatermyfriend.org>

On Mon, May 4, 2009 at 2:59 AM, Frank Terbeck <ft@bewatermyfriend.org> wrote:
> An exception is if it is called using the --stdout option,
> which disables format.coverauto, because users of --stdout
> (like git-rebase.sh) usually are not interested in
> cover letters at all.
>

Would it make more sense to just have git-rebase.sh use
--cover-letter=never? I thought configuration variables were defaults
which have to be overridden.

Also, why does this variable even exist? I think Jeff's suggestion is
best, where you can set format.coverletter to always, never, or some
number.

> +       if (!strcmp(var, "format.coverauto")) {
> +               cover_letter = git_config_bool(var, value);;
> +               return 0;
> +       }

Double semi-colon?

Finally, this option is very useful, so keep up the good work.