From: Ramsay Jones Date: Wed, 11 Mar 2026 23:12:19 GMT Subject: Re: [RFC] t: allow use of "sed -E" Message-ID: <77fce76d-07e2-4586-bb6c-f0043d171591@ramsayjones.plus.com> In-Reply-To: On 11/03/2026 9:41 pm, Junio C Hamano wrote: > Junio C Hamano writes: > [snip] >> >> Let's change the rule to allow the "-E" option, which nobody has >> complained against for the past 3 years. We rewrite our first use >> of the "-E" option so that it is caught by the old rule, primarily >> because we do not want to teach our mischievous developers how to >> smuggle in an unwated option undetected by the test lint. And at > > "unwated" -> "unwanted", of course ;-) > >> the same time, loosen the pattern to allow "-E" the same way we >> allow "-n" and friends. >> >> Signed-off-by: Junio C Hamano >> --- >> >> t/check-non-portable-shell.pl | 2 +- >> t/t6030-bisect-porcelain.sh | 2 +- >> 2 files changed, 2 insertions(+), 2 deletions(-) >> >> diff --git c/t/check-non-portable-shell.pl w/t/check-non-portable-shell.pl >> index 6ee7700eb4..dd8af6d08f 100755 >> --- c/t/check-non-portable-shell.pl >> +++ w/t/check-non-portable-shell.pl >> @@ -36,7 +36,7 @@ sub err { >> >> $_ = $line; >> /\bcp\s+-a/ and err 'cp -a is not portable'; >> - /\bsed\s+-[^efn]\s+/ and err 'sed option not portable (use only -n, -e, -f)'; >> + /\bsed\s+-[^Eefn]\s+/ and err 'sed option not portable (use only -n, -e, -f)'; .. and, perhaps, add -E to the error message? ATB, Ramsay Jones >> /\becho\s+-[neE]/ and err 'echo with option is not portable (use printf)'; >> /^\s*declare\s+/ and err 'arrays/declare not portable'; >> /^\s*[^#]\s*which\s/ and err 'which is not portable (use type)'; >> diff --git c/t/t6030-bisect-porcelain.sh w/t/t6030-bisect-porcelain.sh >> index cdc0270640..1ba9ca219e 100755 >> --- c/t/t6030-bisect-porcelain.sh >> +++ w/t/t6030-bisect-porcelain.sh >> @@ -402,7 +402,7 @@ test_expect_success 'git bisect run: negative exit code' " >> git bisect good $HASH1 && >> git bisect bad $HASH4 && >> ! git bisect run ./fail.sh 2>err && >> - sed -En 's/.*(bisect.*code) (-?[0-9]+) (from.*)/\1 -1 \3/p' err >actual && >> + sed -E -n 's/.*(bisect.*code) (-?[0-9]+) (from.*)/\1 -1 \3/p' err >actual && >> test_cmp expect actual >> " >> >