From: Jeff Hostetler Date: Fri, 19 May 2023 17:49:09 GMT Subject: Re: Which macOS versions does Git support? Message-ID: <7778a454-fefd-5b8a-212b-ab46681ccfd4@jeffhostetler.com> In-Reply-To: <20230519090917.GB3515410@coredump.intra.peff.net> On 5/19/23 5:09 AM, Jeff King wrote: > On Fri, May 19, 2023 at 08:00:00AM +0100, M Hickford wrote: > >> Hi. Does anyone know which macOS versions are supported by Git? > > I don't think we have any formal decision here (or for any other > platform; it is usually a cost/benefit for individual features we may > want to depend on). > >> Motivation: I spotted that git-credential-osxkeychain.c uses a >> deprecated API. SecKeychainAddInternetPassword was deprecated in >> 2014's macOS 10.10 [1]. Replacement SecItemAdd was introduced in >> 2009's macOS 10.6 [2]. > > +cc Taylor, who I know was looking into this recently. > > I'd guess that anything older than 2009 is probably not worth worrying > about. > >> Further motivation: If I understand the documentation correctly, the >> new SecItemAdd API has better support for storing attributes alongside >> secrets, which might be handy for storing Git credential's new >> password_expiry_utc attribute (d208bfd, credential: new attribute >> password_expiry_utc, 2023-02-18). > > Yeah, that would be a nice bonus (in addition to avoiding a deprecated > interface). > > -Peff I had similar issues last year with older versions of the compiler tools and/or an API that I was using in FSMonitor. https://lore.kernel.org/git/xmqqsfhtphpl.fsf@gitster.g/T/ https://lore.kernel.org/git/pull.1375.git.1665085395.gitgitgadget@gmail.com/ IIRC my API usage needs 10.6 or newer. Jeff