From: Jonathan Tan <jonathantanmy@google.com>
Date: Tue, 14 Feb 2017 16:58:49 GMT
Subject: Re: [PATCH 0/7] grep rev/path parsing fixes
Message-ID: <77693036-756d-3be3-c885-ca7891da533c@google.com>
In-Reply-To: <20170214060021.einv7372exbxa23z@sigill.intra.peff.net>

On 02/13/2017 10:00 PM, Jeff King wrote:
> I've fixed that, along with a few other bugs and cleanups. The complete
> series is below. Patch 2 is your (untouched) patch. My suggestions for
> your test are in patch 3, which can either remain on its own or be
> squashed in.
>
>   [1/7]: grep: move thread initialization a little lower
>   [2/7]: grep: do not unnecessarily query repo for "--"
>   [3/7]: t7810: make "--no-index --" test more robust
>   [4/7]: grep: re-order rev-parsing loop
>   [5/7]: grep: fix "--" rev/pathspec disambiguation
>   [6/7]: grep: avoid resolving revision names in --no-index case
>   [7/7]: grep: do not diagnose misspelt revs with --no-index

Thanks - these look good to me. I replied to 6/7 with a comment, but I 
also think that these are good as-is. Also, 3/7 can probably be squashed in.