From: Jens Krüger Date: Tue, 03 Apr 2018 13:29:13 GMT Subject: Re: Test 5561 failed Message-ID: <7769193d-f10d-9e3e-6c9d-c21a4a72485f@frm2.tum.de> In-Reply-To: <20180403131447.GB18824@sigill.intra.peff.net> Am 03.04.2018 um 15:14 schrieb Jeff King: > On Tue, Apr 03, 2018 at 01:43:37PM +0200, Jens Krüger wrote: > >> expecting success: GET refs/heads/master "404 Not Found" not ok 2 - >> direct refs/heads/master not found > That GET function is: > > GET() { > curl --include "$HTTPD_URL/$SMART/repo.git/$1" >out 2>/dev/null && > tr '\015' Q sed ' > s/Q$// > 1q > ' >act && > echo "HTTP/1.1 $2" >exp && > test_cmp exp act > } > > The tarball you sent shows "out" as empty, and "act" is missing. So > "curl" produced no output, and we did not make it as far as the tr/sed > pipe. Just a guess, but are you missing the "curl" command-line tool on > your system? If so, "apt install curl" should fix the failure. Yes, the missing curl program was the reason, but I didn't find any hint about the missed program in the log output. The output will be suppressed by the '2>/dev/null' in lines: 9 and 22 of the t5561-http-backend.sh script. Nevertheless many thanks for helping. > As far as code changes in Git, perhaps (assuming my guess is right): > > - drop the redirect of stderr here; the test suite already handles > hiding stderr from the user (without "-v"), and in "-v" mode you > probably would have gotten a useful error like "curl: not found" > > - it's rare but possible to have libcurl installed (which is needed > for the server side, and what we key on for running the httpd tests) > but not the curl binary. This test probably should check for the > existence of the curl binary as a prerequisite. > > -Peff