From: Aleen 徐沛文 <pwxu@coremail.cn>
Date: Mon, 22 Nov 2021 07:19:18 GMT
Subject: Re: [PATCH v8 2/2] am: support --empty=<option> to handle empty patches
Message-ID: <775978a8.236.17d46836f86.Coremail.pwxu@coremail.cn>
In-Reply-To: <xmqqbl2ck6u1.fsf@gitster.g>


> Perhaps this line should imitate what Hans Krentel did in
> https://lore.kernel.org/git/pull.1143.git.git.1637347813367.gitgitgadget@gmail.com/,
> i.e. real name first, and then (nickname) in parentheses.
> 
> Also, the in-body "From:" line should match the sign off.
> 
> I corrected what has been queued in 'seen' manually when I applied
> the previous round.
> 
> > +--empty=(die|drop|keep)::
> 
> This is the only change relative to what is queued (we had
> "--empty-commit", which is remnant from an earlier iteration), and
> it makes the documentation consistent with what the code does.
> 
> Good.

It seems there is something wrong when submitting via "徐沛文 (Aleen) <aleen42@vip.qq.com>".