From: Remi Galan Alfonso Date: Sat, 13 Jun 2015 23:17:05 GMT Subject: Re: [PATCH/RFCv5 3/3] git rebase -i: add static check for commands and SHA-1 Message-ID: <775816946.447663.1434237425837.JavaMail.zimbra@ensimag.grenoble-inp.fr> In-Reply-To: Matthieu Moy writes: > Remi Galan Alfonso writes: > > > It is mainly because here the SHA-1 is a long one (40 chars) > > OK, but then the minimum would be to add a comment saying that. > > Now, this makes me wonder why you are doing the check after the sha1 > expansion and not before. Also, when running `git bisect --edit-todo`, I > do get the short sha1. So, there's a piece of code doing what you want > somewhere already. You may want to use it. Originally I did the whole checking after the expansion because I though that it was a better idea to avoid doing it myself (Comparing the whole SHA-1 instead of partial ones to find missing ones made more sense for me since otherwise I would have to check if one is the prefix of the other or expand to the same size before comparing). However I agree that adding a comment would make things clearer. Will probably do that. Thank you, Rémi