From: Aleen 徐沛文 <pwxu@coremail.cn>
Date: Tue, 16 Nov 2021 10:31:45 GMT
Subject: Re: [PATCH v4 2/2] am: support --empty-commit option to handle empty patches
Message-ID: <77268d7d.3ce.17d284d7732.Coremail.pwxu@coremail.cn>
In-Reply-To: <23de56a6-5b41-d8be-d59c-5a4e025ccd73@gmail.com>

> > +--empty-commit=(die|skip|asis)::
> > +	The command usually errors out when seeing an input e-mail
> > +	message that lacks a patch. When this option is set to
> > +	'skip', skip such an e-mail message without outputting error.
> > +	When this option is set to 'asis', create an empty commit,
> > +	recording the contents of the e-mail message as its log.
> > +	'die' is specified by default.
> 
> This feels sufficiently similar to the case of handling empty commits in 
> 'git rebase' that it is worth trying to have a similar user interface. 
> Otherwise the two commands have two different option names doing more or 
> less the same thing. 'git rebase' has --empty=[drop,keep,ask] where drop 
> is the default. If am were to accept --empty=[drop,keep,die] it would 
> offer a similar user experience.
> 
> Best Wishes
> 
> Phillip

Dears Phillip,

It seems a good idea. Can Hamano make a decision?

Aleen