From: Brandon Casey <casey@nrlssc.navy.mil>
Date: Wed, 02 Jun 2010 14:46:14 GMT
Subject: Re: [PATCH 1/5] t/t5800: skip if python version is older than 2.5
Message-ID: <771D_fbE1nXD6XdR0EsexE96n7NZJ1WvuJ__1wNJTGHLKi4dsHGk0g@cipher.nrlssc.navy.mil>
In-Reply-To: <4C05FC18.4090402@viscovery.net>

On 06/02/2010 01:37 AM, Johannes Sixt wrote:
> Am 6/2/2010 2:13, schrieb Brandon Casey:
>> +if ! test_have_prereq PYTHON_2_5_OR_NEWER
>>  then
>> +	say 'skipping git remote-testgit tests: requires Python 2.5 or newer'
> ...
>> +++ b/t/test-lib.sh
>> +if test_have_prereq PYTHON && "$PYTHON_PATH" -c '
>> +import sys
>> +if sys.hexversion < 0x02050000:
>> +    sys.exit(1)
>> +'
>> +then
>> +	test_set_prereq PYTHON_2_5_OR_NEWER
>> +fi
> 
> Please don't burden all test script invocations with this check when the
> result is used in only one place.

Very good point.