From: Jay Soffian <jaysoffian@gmail.com>
Date: Sun, 19 Apr 2009 01:51:43 GMT
Subject: Re: [PATCH RFC3.5 05/12] send-email: Improve redability and error-handling in send_message's sendmail code
Message-ID: <76718490904181851g2701ce59x614ea60452b914ce@mail.gmail.com>
In-Reply-To: <1240074128-16132-6-git-send-email-mfwitten@gmail.com>

On Sat, Apr 18, 2009 at 1:02 PM, Michael Witten <mfwitten@gmail.com> wrote:
> diff --git a/git-send-email.perl b/git-send-email.perl
> index e2c7954..2727c77 100755
> --- a/git-send-email.perl
> +++ b/git-send-email.perl
> @@ -967,15 +967,22 @@ X-Mailer: git-send-email $gitversion
>        }
>
>        if ($dry_run) {
> +
>                # We don't want to send the email.
> +
>        } elsif ($smtp_server_is_a_command) {
> -               my $pid = open my $sm, '|-';
> -               defined $pid or die $!;
> -               if (!$pid) {
> -                       exec($smtp_server, @sendmail_parameters) or die $!;
> -               }
> -               print $sm "$header\n$message";
> -               close $sm or die $?;
> +
> +               (my $pid = open my $pipe, '|-')
> +                       // die "Could not fork to run '$smtp_server': $!\n";

What is '//' about?

j.