From: Jay Soffian <jaysoffian@gmail.com>
Date: Thu, 19 Mar 2009 15:00:50 GMT
Subject: Re: t5505-remote fails on Windows
Message-ID: <76718490903190800o4d82a037mb6fc5bf901c418d8@mail.gmail.com>
In-Reply-To: <7vhc1pai84.fsf@gitster.siamese.dyndns.org>

On Thu, Mar 19, 2009 at 7:02 AM, Junio C Hamano <gitster@pobox.com> wrote:
>> Do we really want an API for that?  Calling qsort() directly should be
>> obvious enough, no?
>
> I think so.  If it were done like this (notice the lack of double
> indirection in the cmp_fn signature):
>
>    typedef int string_list_item_cmp_fn(const struct string_list_item *, const struct string_list_item *);
>
>    void sort_string_list_with_fn(struct string_list *list, string_list_item_cmp_fn *);
>
> it would have made more sense, though.

Oh, wow, sorry, I didn't even realize Jeff had just added that
function. Somehow I missed that part of his patch.

j.