From: Jay Soffian Date: Thu, 19 Mar 2009 04:56:37 GMT Subject: Re: t5505-remote fails on Windows Message-ID: <76718490903182156y3b2b9d8aw708829a6ed151aa@mail.gmail.com> In-Reply-To: <20090319044313.GA341@coredump.intra.peff.net> On Thu, Mar 19, 2009 at 12:43 AM, Jeff King wrote: > The patch below probably fixes it, but as I can't actually reproduce > here, it is largely untested. Thanks. > As a side note, I find this solution a little bit ugly. String lists > should sort on their strings, not on some other random magic in the util > field. This usage really abuses string_list a bit as a data type because > we have no generic "list" type. I really don't think so. The string_list API accommodates this case quite nicely. So why not? (And anyway, what sane configuration pushes a single local branch to multiple remote branches? But the refspecs allow it, so I accommodated it in builtin-remote and tested for it. I never actually tested whether git push works with it tho.) :-) j.