From: Jay Soffian Date: Wed, 11 Mar 2009 14:57:16 GMT Subject: Re: [PATCH 1/3] bash completion: fix completion issues with fetch, pull, and push Message-ID: <76718490903110757j3b90dcffx4b81d2a02427008b@mail.gmail.com> In-Reply-To: <20090311190227.6117@nanako3.lavabit.com> On Wed, Mar 11, 2009 at 6:02 AM, Nanako Shiraishi wrote: > While people's attention is on the completion, there is one case I wish the completion worked better. > "git log origin..mas[TAB]" and "git log origin...mas[TAB]" work as expected, but the same completion does not work for "git diff". I don't miss the two-dot format but it's often useful to say "git diff origin...master". I just looked and realized to fix this properly, __git_complete_file and __git_complete_revlist need some refactoring, along with the functions that use them. So I'll add it to my todo list, since it's more than 5 minutes of available time I have right now. j.