From: Jay Soffian <jaysoffian@gmail.com>
Date: Tue, 10 Mar 2009 03:05:53 GMT
Subject: Re: [RFH Patch 2/2] http_init(): Fix config file parsing
Message-ID: <76718490903092005n66bca743t67eb7f0ff830d9d7@mail.gmail.com>
In-Reply-To: <7vfxhmce67.fsf@gitster.siamese.dyndns.org>

On Mon, Mar 9, 2009 at 10:19 PM, Junio C Hamano <gitster@pobox.com> wrote:
>  * This is what I need help from people who actually do use http transport
>   and extra set of eyeballs to spot silly mistakes.

It looks sane to me.

> @@ -241,14 +221,18 @@ void http_init(struct remote *remote)
>        if (getenv("GIT_SSL_NO_VERIFY"))
>                curl_ssl_verify = 0;
>
> -       ssl_cert = getenv("GIT_SSL_CERT");
> +       if (getenv("GIT_SSL_CERT"))
> +               ssl_cert = getenv("GIT_SSL_CERT");
>  #if LIBCURL_VERSION_NUM >= 0x070902
> -       ssl_key = getenv("GIT_SSL_KEY");
> +       if (getenv("GIT_SSL_KEY"))
> +               ssl_key = getenv("GIT_SSL_KEY");
>  #endif
>  #if LIBCURL_VERSION_NUM >= 0x070908
> -       ssl_capath = getenv("GIT_SSL_CAPATH");
> +       if (getenv("GIT_SSL_CAPATH"))
> +               ssl_capath = getenv("GIT_SSL_CAPATH");
>  #endif
> -       ssl_cainfo = getenv("GIT_SSL_CAINFO");
> +       if (getenv("GIT_SSL_CAINFO"))
> +               ssl_cainfo = getenv("GIT_SSL_CAINFO");

Would these be a little cleaner with a temporary variable. e.g.

char *value;

if ((value = getenv("GIT_SSL_CERT")))
    ssl_cert = value;


j.