From: Jay Soffian Date: Fri, 20 Feb 2009 22:55:15 GMT Subject: Re: [PATCH 4/4] remote: new show output style Message-ID: <76718490902201455y22b8a861x246fd22845ae282c@mail.gmail.com> In-Reply-To: <499F2FF6.10601@xiplink.com> On Fri, Feb 20, 2009 at 5:34 PM, Marc Branchaud wrote: > All valid points. But, dang it, I really think intelligently adding that > extra space the right thing to do. Already coded. :-) > It wouldn't be all that tedious -- you could detect the need for the extra > space in config_read_branches() the first time type is set to REBASE, no? What is that about everything being easy for the man who doesn't have to do it? :-) (It was no big deal, I just needed to rework a few things cause I'd painted myself into a corner.) >> I left that out on purpose. The only folks with push refspecs put them >> their manually, and the raw refspec is clearer and more concise than >> any English words can convey. That was my reasoning anyway. > > Fair enough. Yeah, I'm fixing this too by properly expanded out the refspecs the same way that it's done by {builtin-send-pack, http-push}.c. Hopefully I can have a patch out later today. j.