From: Jay Soffian <jaysoffian@gmail.com>
Date: Sun, 15 Feb 2009 14:13:09 GMT
Subject: Re: [PATCH] builtin-remote: better handling of multiple remote HEADs
Message-ID: <76718490902150613i79517e6dwcec8e1e40c56bcc8@mail.gmail.com>
In-Reply-To: <20090215052740.GA11522@coredump.intra.peff.net>

On Sun, Feb 15, 2009 at 12:27 AM, Jeff King <peff@peff.net> wrote:
> On Sat, Feb 14, 2009 at 05:30:30AM -0500, Jay Soffian wrote:
>
>> +test_expect_success 'set-head --auto fails w/multiple HEADs' '
>> +     (cd test &&
>> +      test_must_fail git remote set-head --auto two >& output &&
>> +     test_cmp expect output)
>
> I missed it before, but there is a typo in this test (>&) that causes it
> to barf.

Didn't barf for me, but it turns out it's because it's a bash'ism[1],
and that's the default /bin/sh on OS X. Out of curiosity, on what
platform did it fail for you?

[1] Redirecting Standard Output and Standard Error
       Bash allows both the standard output (file descriptor 1) and
the  standard  error
       output  (file  descriptor 2) to be redirected to the file whose
name is the expan-
       sion of word with this construct.

       There are two formats for redirecting standard output and standard error:

              &>word
       and
              >&word

       Of the two forms, the first is preferred.  This is semantically
equivalent to

              >word 2>&1

j.