From: Jay Soffian <jaysoffian@gmail.com>
Date: Fri, 06 Feb 2009 21:47:57 GMT
Subject: Re: [PATCHv2] gitweb: Better regexp for SHA-1 committag match
Message-ID: <76718490902061347h5bc35e7et9e1b66bf9dd2c93a@mail.gmail.com>
In-Reply-To: <alpine.DEB.1.00.0902061403130.7377@intel-tinevez-2-302>

On Fri, Feb 6, 2009 at 8:03 AM, Johannes Schindelin
<Johannes.Schindelin@gmx.de> wrote:
> Hi,
>
> On Fri, 6 Feb 2009, Jakub Narebski wrote:
>
>> diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
>> index f27dbb6..5dcc108 100755
>> --- a/gitweb/gitweb.perl
>> +++ b/gitweb/gitweb.perl
>> @@ -1364,7 +1364,7 @@ sub format_log_line_html {
>>       my $line = shift;
>>
>>       $line = esc_html($line, -nbsp=>1);
>> -     if ($line =~ m/([0-9a-fA-F]{8,40})/) {
>> +     if ($line =~ m/\b([0-9a-fA-F]{8,40})\b(!?\@)/) {
>
> Looks good to me!

I wonder if just matching lower-case a-f would be sufficient as well?

j.