From: Jay Soffian Date: Wed, 28 Jan 2009 14:28:50 GMT Subject: Re: [PATCH v2 1/2] git-am: emit usage when called w/o arguments and w/o patch on stdin Message-ID: <76718490901280628y3761b41dhd2e544093e01e209@mail.gmail.com> In-Reply-To: <7vhc3kxdwm.fsf@gitster.siamese.dyndns.org> On Tue, Jan 27, 2009 at 11:17 PM, Junio C Hamano wrote: > Jay Soffian writes: > >> + test $# = 0 && test -t 0 && usage > > Sorry to be dense. Why isn't your patch the above single liner? > "Also ensure that $dotest is cleaned up if user manages to interupt mailsplit while it is processing input, but not if mailsplit exits non-zero due to error." j.