From: Jay Soffian Date: Wed, 14 Jan 2009 14:22:45 GMT Subject: Re: [PATCH 2/3] git-daemon: use getnameinfo to resolve hostname Message-ID: <76718490901140622i1c29cd96u1b30042ad9ecb5d9@mail.gmail.com> In-Reply-To: <20090114122536.GA5939@coredump.intra.peff.net> On Wed, Jan 14, 2009 at 7:25 AM, Jeff King wrote: > So at the very least, you should be adding REMOTE_HOST in _addition_ to > REMOTE_ADDR, not instead of. But that still leaves one final concern, > which is that some git-daemon admins might not want to pay the cost for > a reverse lookup for every request. It's extra network traffic, and adds > extra latency to the process (but I don't personally run git-daemon, and > I don't know whether big sites like kernel.org actually care about > this). Speaking for large sites everywhere, yes they do care. Enabling DNS lookups must be configurable. j.