From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Fri, 02 Oct 2015 10:13:40 GMT
Subject: Re: [PATCH/RFC 1/2] sha1_file: close all pack files after running
Message-ID: <763ac2b63d56d250e5e1a27f490f79db@dscho.org>
In-Reply-To: <33b74e875c7298f67640f5850e88c152@dscho.org>

Hi Max,

On 2015-10-02 12:05, Johannes Schindelin wrote:

> On 2015-10-01 05:29, Max Kirillov wrote:
>> When a builtin has done its job, but waits for pager or not waited
>> by its caller and still hanging it keeps pack files opened.
>> This can cause a number of issues, for example on Windows git gc
>> cannot remove the packs.

Could you do me another favor? It seems that you want to work on this, so I will step back (I have to take off for the weekend very soon anyway, so I am really glad that you take care of it). But I would really love to see the line

This fixes https://github.com/git-for-windows/git/issues/446

in the commit message, as this will keep the connection between the fix and the original report.

Thanks,
Dscho