From: Jeff Hostetler <git@jeffhostetler.com>
Date: Wed, 06 Jun 2018 21:05:59 GMT
Subject: Re: [PATCH v7 2/2] json-writer: t0019: add Python unit test
Message-ID: <75fc23f9-5a76-a4fc-9135-881a4e317408@jeffhostetler.com>
In-Reply-To: <20180606171052.GI3094@zaya.teonanacatl.net>



On 6/6/2018 1:10 PM, Todd Zullinger wrote:
> git@jeffhostetler.com wrote:
>> +# As a sanity check, ask Python to parse our generated JSON.  Let Python
>> +# recursively dump the resulting dictionary in sorted order.  Confirm that
>> +# that matches our expectations.
>> +test_expect_success PYTHON 'parse JSON using Python' '
> [...]
>> +	python "$TEST_DIRECTORY"/t0019/parse_json_1.py <output.json >actual &&
> 
> Would this be better using $PYTHON_PATH rather than
> hard-coding python as the command?
> 

good catch!
thanks
Jeff