From: Derrick Stolee <stolee@gmail.com>
Date: Fri, 07 Sep 2018 13:12:12 GMT
Subject: Re: [PATCH 1/2] commit-graph write: add progress output
Message-ID: <75c8f1f1-d836-7dda-b30b-6c2fec73b194@gmail.com>
In-Reply-To: <87h8j1qy59.fsf@evledraar.gmail.com>

On 9/7/2018 8:40 AM, Ævar Arnfjörð Bjarmason wrote:
> On Tue, Sep 04 2018, Ævar Arnfjörð Bjarmason wrote:
>
>> Before this change the "commit-graph write" command didn't report any
>> progress. On my machine this command takes more than 10 seconds to
>> write the graph for linux.git, and around 1m30s on the
>> 2015-04-03-1M-git.git[1] test repository, which is a test case for
>> larger monorepos.
> There's a fun issue with this code that I'll fix, but thought was
> informative to send a mail about.
>
> Because the graph verification happens in the main "git gc" process, as
> opposed to everything else via external commands, so all this progress
> output gets written to .git/gc.log.
>
> Then next time we do a "gc --auto" we vomit out a couple of KB of
> progress bar output at the user, since spot that the gc.log isn't empty.
Good catch! (I do want to clarify that the graph _writing_ happens 
during 'git gc' since 'git commit-graph verify' is a different thing.)