From: Remi Galan Alfonso <remi.galan-alfonso@ensimag.grenoble-inp.fr>
Date: Wed, 03 Jun 2015 17:53:26 GMT
Subject: Re: [PATCH/RFCv4 2/2] git rebase -i: warn about removed commits
Message-ID: <758899838.77480.1433354006473.JavaMail.zimbra@ensimag.grenoble-inp.fr>
In-Reply-To: <vpq1thsbsko.fsf@anie.imag.fr>

Matthieu Moy <Matthieu.Moy@grenoble-inp.fr> writes:
> You're using $1 and $2 only to redirect input and output. I would find
> it more elegant to write todo_list_to_sha_list as a filter, and do the
> redirection in the call site (to keep the option of using
> todo_list_to_sha_list in a pipe).

If I understood correctly, then the calling line would look like:
> todo_list_to_sha_list <"$todo".backup >"$todo".oldsha1
?

Should I do the same for the function warn_file ?
Meaning
> warn_file <"$todo".miss
instead of
> warn_file "$todo".miss

The other points mentioned have been corrected.

Thanks,
Rémi