From: Stefan Haller Date: Sat, 21 Nov 2020 17:47:37 GMT Subject: Re: [PATCH v2] git-gui: Basic dark mode support Message-ID: <7553c99f-1dea-0c1d-e5b0-2103333a76b7@haller-berlin.de> In-Reply-To: <20201008130741.mz7k3uy65xdbdkeh@yadavpratyush.com> On 08.10.20 15:07, Pratyush Yadav wrote: > On 26/09/20 05:54PM, Serg Tereshchenko wrote: >> Removed forced colors in ttext widget calls, >> instead using Text.Background/Foreground options. >> This way colors can be configured dependent on current theme, and even >> overriden by user via .Xresources. >> >> Extracted colors for in_sel/in_diff tags into colors:: namespace, >> where they can be configured from current theme colors. >> >> Signed-off-by: Serg Tereshchenko >> --- >> git-gui.sh | 17 +++++++++++------ >> lib/themed.tcl | 38 ++++++++++++++++++++++++++++++++++++++ >> 2 files changed, 49 insertions(+), 6 deletions(-) > > Merged to git-gui/master. Thanks. This caused a regression: when selecting text in the diff pane or in the commit message window, the selected text now has a black background (on Mac and on Windows, I don't have a Linux system to test this). This looks quite ugly; it used to be light blue on both of these systems. When setting gui.usettk to 0, it is light blue as before (as expected). I'm sorry that I can't give any suggestions how to fix this, because I have trouble understanding the code related to themes, even after staring at it for quite a while this afternoon. Best, Stefan