From: phillip.wood123@gmail.com Date: Mon, 07 Oct 2024 09:00:15 GMT Subject: Re: [PATCH v3 2/2] [Outreachy][Patch v1] t3404: employing test_line_count() to replace test Message-ID: <75485b2f-4ce4-40f4-bed2-343b3adc830e@gmail.com> In-Reply-To: Hi Patrick On 07/10/2024 07:05, Patrick Steinhardt wrote: > > Oh, you already do the change I proposed on the first commit. It's a bit > funny that we first change things one way and then touch it up again in > another commit as it leaves the reviewer wondering for a bit. > > But I guess that's okay, especially for a microproject. So overall I > don't see a strong reason to reroll this series, thanks! It looks like Eric suggested making this change in a separate patch. While they could perhaps be made in the same patch fixing the pipelines and using test_line_count are essentially independent changes so I think splitting them into two patches is good practice and makes sense from pedagogical point of view. Best Wishes Phillip