From: Kaartic Sivaraam <kaartic.sivaraam@gmail.com>
Date: Mon, 05 Oct 2026 08:03:46 GMT
Subject: Re: [PATCH 1/7] meson: avoid recompiling HTTP sources several times
Message-ID: <74b22ec2-280e-4fca-9f5b-c21a7c12a78f@gmail.com>
In-Reply-To: <20260924-pks-meson-improvements-v1-1-90b7f79f1c4e@pks.im>

On 9/24/26 19:39, Patrick Steinhardt wrote:
> We only link curl into a subset of our subcommands. Consequently, as
> both "http.c" and "http-walker.c" depend on curl, we don't compile these
> into "libgit.a" but instead only link those into the commands that
> depend on curl.
> 
> In Meson, we wire these dependencies into the target executables by
> using the `sources:` keyword. But this has the consequence that we're
> recompiling those multiple several times, once for every different

s/multiple several/multiple/

Rest of the patch look good to me.

-- 
Sivaraam