From: Johannes Sixt <j6t@kdbg.org>
Date: Tue, 25 Apr 2017 18:18:08 GMT
Subject: Re: [PATCH v7 1/2] exec_cmd: expose is_executable function
Message-ID: <73f07d3e-b2a2-0073-8fba-6f7f51f64a7d@kdbg.org>
In-Reply-To: <20170425175446.113553-1-bmwill@google.com>

Am 25.04.2017 um 19:54 schrieb Brandon Williams:
> Move the logic for 'is_executable()' from help.c to exec_cmd.c and
> expose it so that callers from outside help.c can access the function.

The function is quite low-level. IMO, run-command.[ch] would be a better 
home for it. Additionally, that would reduce the number of files that 
contain #ifdef GIT_WINDOWS_NATIVE.

-- Hannes