From: Ben Knoble <ben.knoble@gmail.com>
Date: Sat, 20 Sep 2025 22:25:30 GMT
Subject: Re: [PATCH v3 01/10] xdiff: delete static forward declarations in xprepare
Message-ID: <7323B02B-4273-4952-83EC-CD467A2365B5@gmail.com>
In-Reply-To: <20250920184638.GA1010995@coredump.intra.peff.net>


> Le 20 sept. 2025 à 14:46, Jeff King <peff@peff.net> a écrit :
> 
> On Sat, Sep 20, 2025 at 01:46:19PM -0400, Ben Knoble wrote:
> 
>>>> Best-viewed-with: --color-moved
>>> 
>>> Two comments.
>>> 
>>> - This is a bit unusual to see in the trailer.
>> 
>> This was (loosely!) my suggestion, and I think Peff has once or twice
>> done something similar.
> 
> I don't think I've ever used a trailer like that, but I do sometimes
> mention it in prose. I'll sometimes put it in comments below the "---"
> line, though.
> 
> -Peff

Silly memory. Sorry :)


> PS I sometimes find:
> 
>     git log --format='%(trailers:only,keyonly)' |
>     sort | uniq -c | sort -rn
> 
>   amusing to look through for this sort of thing.