From: correctmost Date: Fri, 09 Jan 2026 01:24:01 GMT Subject: [Bug] hook: -Wanalyzer-deref-before-check warning in run_hooks_opt Message-ID: <72d123b8-b75e-4b1d-8506-95eb9ad350da@app.fastmail.com> Hi, GCC 15.2.1 warns about a potential NULL pointer dereference in run_hooks_opt on the master branch: --- ../hook.c: In function ‘run_hooks_opt’: ../hook.c:167:12: error: check of ‘options’ for NULL after already dereferencing it [-Werror=analyzer-deref-before-check] 167 | if (!options) | ^ [...snip...] │ 156 | .ungroup = options->ungroup, │ | ~~~~~~~~~~~~~~~~ │ | | │ | (7) pointer ‘options’ is dereferenced here │...... │ 167 | if (!options) │ | ~ │ | | │ | (8) pointer ‘options’ is checked for NULL here but it was already dereferenced at (7) │ --- This does seem like a real bug, though I'm not sure how likely it is to occur. It looks like the warning was introduced in merge commit f406b89552 ("Use hook API to replace ad-hoc invocation of hook scripts with the run_command() API."). I noticed the warning while compiling commit d529f3a19736 on Arch Linux. Thanks!