From: René Scharfe <l.s.r@web.de>
Date: Thu, 07 Sep 2023 20:20:53 GMT
Subject: Re: [PATCH] grep: use OPT_INTEGER_F for --max-depth
Message-ID: <724641d2-1cba-3768-6008-01e8a1cdca4e@web.de>
In-Reply-To: <20230905072122.GG199565@coredump.intra.peff.net>

Am 05.09.23 um 09:21 schrieb Jeff King:
> On Sat, Sep 02, 2023 at 08:54:54PM +0200, René Scharfe wrote:
>
> In general, I wonder how many of the results from:
>
>   git grep '{ OPTION'
>
> could be converted to use the macros and end up more readable. There are
> a number of OPTARG ones, which I guess can't use macros. Looks like
> there are a handful of others (mostly for OPT_HIDDEN).

Indeed, and I have a semantic patch for that, but mostly because the
macros allow injecting a type check.

OPTARG would need a new macro to allow specifying the default value.  Or
is there a variadic macro trick that we could use?

René