From: Piotr Szlazak Date: Sat, 19 Oct 2024 16:46:59 GMT Subject: Re: [PATCH v2] doc: document how uploadpack.allowAnySHA1InWant impact other allow options Message-ID: <72184384-07ff-4f74-91d7-280ca78407b5@gmail.com> In-Reply-To: On 19.10.2024 18:39, Piotr Szlazak via GitGitGadget wrote: > From: Piotr Szlazak > > Document how setting of `uploadpack.allowAnySHA1InWant` > influences other `uploadpack` options - `allowTipSHA1InWant` > and `allowReachableSHA1InWant`. > > Signed-off-by: Piotr Szlazak > --- > doc: document how uploadpack.allowAnySHA1InWant impact other allow > options > > Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-git-1814%2Fpszlazak%2Fupload-pack-allow-flags-v2 > Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-git-1814/pszlazak/upload-pack-allow-flags-v2 > Pull-Request: https://github.com/git/git/pull/1814 > > Range-diff vs v1: > > 1: 8a2673bdf31 < -: ----------- upload-pack: fix how ALLOW_ANY_SHA1 flag is disabled > -: ----------- > 1: 2a9fa4dabba doc: document how uploadpack.allowAnySHA1InWant impact other allow options > > > Documentation/config/uploadpack.txt | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/Documentation/config/uploadpack.txt b/Documentation/config/uploadpack.txt > index 16264d82a72..0e1dda944a5 100644 > --- a/Documentation/config/uploadpack.txt > +++ b/Documentation/config/uploadpack.txt > @@ -25,7 +25,11 @@ uploadpack.allowReachableSHA1InWant:: > uploadpack.allowAnySHA1InWant:: > Allow `upload-pack` to accept a fetch request that asks for any > object at all. > - Defaults to `false`. > + It implies `uploadpack.allowTipSHA1InWant` and > + `uploadpack.allowReachableSHA1InWant`. If set to `true` it will > + enable both of them, it set to `false` it will disable both of > + them. > + By default not set. > > uploadpack.keepAlive:: > When `upload-pack` has started `pack-objects`, there may be a > > base-commit: 34b6ce9b30747131b6e781ff718a45328aa887d0 PATCH v2 which updates documentation. I wrote 'By default not set', as definitely 'Defaults to `false`' in not true. Only when `uploadpack.allowAnySHA1InWant` set to `true` or `false` it will affect reported capabilities. Regards, Piotr