From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Sat, 18 Apr 2015 14:54:03 GMT
Subject: Re: [PATCH v2 2/2] t0027: Support NATIVE_CRLF
Message-ID: <7216168da473ed5cda5b16bca236a3ec@www.dscho.org>
In-Reply-To: <xmqq8udqpius.fsf@gitster.dls.corp.google.com>

Hi Junio,

On 2015-04-17 23:04, Junio C Hamano wrote:
> Johannes Schindelin <johannes.schindelin@gmx.de> writes:
> 
>> On 2015-04-17 17:44, Torsten Bögershausen wrote:
>>> Without this patch, t0027 expects the native end-of-lines to be a single
>>> line feed character. On Windows, however, we set it to a carriage return
>>> character followed by a line feed character. Thus, we have to modify
>>> t0027 to expect different warnings depending on the end-of-line markers.
>>>
>>> Adjust the check of the warnings and use these macros:
>>>   WILC:  Warn if LF becomes CRLF
>>>   WICL:  Warn if CRLF becomes LF
>>>   WAMIX: Mixed line endings: either CRLF->LF or LF->CRLF
>>>
>>> Improve the information given by check_warning():
>>> Use test_cmp to show which warning is missing (or should'n t be there)
>>>
>>> Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
>>> Signed-off-by: Torsten Bögershausen <tboegi@web.de>
>>
>> Thank you so much!
>> Dscho
> 
> Thanks, is that "Acked-by: Dscho" for both patches?

Oops, yes:

Acked-by: Johannes Schindelin <johannes.schindelin@gmx.de>

Sorry!
Dscho