From: Philip Oakley Date: Sat, 27 Jul 2013 11:26:26 GMT Subject: Re: [PATCHv3] git-tag man: when to use lightweight or annotated tags Message-ID: <720060083F5C476A905C09146E7CD711@PhilipOakley> In-Reply-To: <51F3A358.5000807@gmail.com> From: "Daniele Segato" > On 07/26/2013 09:06 PM, Jeff King wrote: >> On Fri, Jul 26, 2013 at 07:33:01PM +0200, Daniele Segato wrote: >> >>> stress the difference between the two with suggestion on when the >>> user >>> should use one in place of the other. >>> >>> Signed-off-by: Daniele Segato >> >> The intent of your patch seems reasonable to me. There are a few >> minor >> language and typographical mistakes, and the patch itself is >> whitespace-damaged. > > Hi Jeff, > > thanks for the feedback, very appreciated. > > But I don't understand what's wrong with the whitespaces. > > Can you explain to me what's wrong and how I can avoid the issue? > > I use thunderbird in text mode to send emails, should I use something > else? what? Try 'git format-patch' and 'git send-email'. The format-patch man page even has a note about Thunderbird corruptions. Philip > >> >> I also do not know that it is accurate to say "most git commands >> ignore >> lightweight tags". It is really only "naming" ones like "git >> describe". >> >> Here is a re-send of your patch with the fixups I would recommend. >> > > Thanks, it's obviously better. > > I'll send this new version as soon as you or someone else explain me > how to fix the whitespace damage. > [snip]