From: Vipul Kumar <kumar@onenetbeyond.org>
Date: Tue, 14 Dec 2021 03:58:31 GMT
Subject: Re: List all commits of a specified file in oldest to newest order
Message-ID: <71d21b15-a5db-dd7e-bc81-06bbef995e31@onenetbeyond.org>
In-Reply-To: <211109.864k8lvesb.gmgdl@evledraar.gmail.com>

Hi, sorry for delay reply. I was busy with some other works and couldn't 
find the time to look into it.

On 11/9/21 9:42 AM, Ævar Arnfjörð Bjarmason wrote:
> 
>> Thanks, I didn't know "reverse" would change the traversal order. When
>> I looked for "--reverse" option in git-log(1), this what I found:
>>
>>    --reverse
>>        Output the commits chosen to be shown (see Commit Limiting
>>        section above) in reverse order. Cannot be combined with
>>       --walk-reflogs.
>>
>>  From this, I inferred that "--follow" would choose the commits and
>> "--reverse" reverses those commits order. Can we improve the wording
>> here? Especially, about "reverse" changes the traversing order.
> 
> Yes, definitely. Suggestions most welcome :)

   --reverse
       Traverse the commits chosen to be shown (see Commit Limiting 
section above) in reverse order. Cannot be combined with --walk-reflogs.

If we don't want to disallow combination of "--follow" and "--reverse", 
just like "--walk-reflogs" as combination doesn't make any sense[1]. We 
could do this:

   --reverse
       Traverse the commits chosen to be shown (see Commit Limiting 
section above) in reverse order. Cannot be combined with --walk-reflogs. 
Combination of --follow and --reverse won't produce an expected output, 
if we also want to follow renames. If there is nothing to follow it 
should behave as expected.

[1]: 
https://public-inbox.org/git/6c6ef97c-9de5-176f-f328-c4dffd96d495@onenetbeyond.org/

Does it sound good to you?

-v