From: Phillip Wood Date: Mon, 03 Mar 2025 14:32:57 GMT Subject: Re: [PATCH] meson: fix building technical and howto docs Message-ID: <71b5dec1-a50b-4624-87a5-b1ede8767166@gmail.com> In-Reply-To: Hi Patrick On 03/03/2025 10:17, Patrick Steinhardt wrote: > On Sun, Mar 02, 2025 at 04:02:30PM +0000, Phillip Wood via GitGitGadget wrote: >> From: Phillip Wood >> >> When our asciidoc files were renamed from "*.txt" to "*.adoc" in >> 1f010d6bdf7 (doc: use .adoc extension for AsciiDoc files, 2025-01-20) >> the "meson.build" file in "Documentation" was updated but the >> "meson.build" files in the "technical" and "howto" subdirectories were >> not. This causes the meson build to fail when configured with >> -Ddocs=html. Fix this by updating the relevant "meson.build" files. > > Good catch, thanks! I wonder: do we maybe also want to start building > documentation with Meson so that we would catch issues like this > earlier? I think that would be a good idea. > In any case, I'm happy to defer that to a later point and for now only > land the fix. Yes, I was hoping this minimal fix would be acceptable for inclusion in the upcoming release. We can change the CI once that's out the door. Best Wishes Phillip > Patrick