From: Philip Oakley Date: Mon, 14 Dec 2015 23:57:37 GMT Subject: Re: [PATCH v1 4/4] git gui: allow for a long recentrepo list Message-ID: <71B00739215A4176BA65000AF1CBBBD4@PhilipOakley> In-Reply-To: From: "Eric Sunshine" > On Mon, Dec 14, 2015 at 10:09 AM, Philip Oakley > wrote: >> The gui.recentrepo list may be longer than the maxrecent setting. >> Allow extra space to show any extra entries. >> >> In an ideal world, the git gui would limit the number of entries >> to the maxrecent setting, however the recentrepo config list may >> have been extended outwith the gui, or the maxrecent setting changed > > s/outwith/without/ Ah, it's a Scottish english word, which better 'translates' as as outside, rather than being a commutation ;-) I'll see if there are any other comments before a re-roll. > >> to a reduced value. Further, when testing the gui's recentrepo >> logic it is useful to show these extra, but valid, entries. >> >> Signed-off-by: Philip Oakley >> --- >> diff --git a/git-gui/lib/choose_repository.tcl >> b/git-gui/lib/choose_repository.tcl >> index ad7a888..a08ed4f 100644 >> --- a/git-gui/lib/choose_repository.tcl >> +++ b/git-gui/lib/choose_repository.tcl >> @@ -153,7 +153,7 @@ constructor pick {} { >> -background [get_bg_color $w_body.recentlabel] \ >> -wrap none \ >> -width 50 \ >> - -height $maxrecent >> + -height [expr {$maxrecent + 5}] >> $w_recentlist tag conf link \ >> -foreground blue \ >> -underline 1 >> -- >> 2.5.2.windows.2 > -- > To unsubscribe from this list: send the line "unsubscribe git" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >