From: Phillip Wood Date: Tue, 20 Feb 2024 10:53:06 GMT Subject: Re: [PATCH 0/5] promise: introduce promises to track success or error Message-ID: <70a81f5a-32d8-4517-83ea-8019be5f97d5@gmail.com> In-Reply-To: <20240220025722.GE2713741@coredump.intra.peff.net> Hi Peff On 20/02/2024 02:57, Jeff King wrote: > On Mon, Feb 19, 2024 at 02:25:29PM +0000, Phillip Wood wrote: > >> I'm sure this has been discussed in the past but I didn't manage to turn >> anything up with a quick search of the archive on lore.kernel.org. > > There's some discussion in this sub-thread: > > https://lore.kernel.org/git/20171103191309.sth4zjokgcupvk2e@sigill.intra.peff.net/ > > that also references this earlier thread: > > https://lore.kernel.org/git/20160927191955.mympqgylrxhkp24n@sigill.intra.peff.net/ Thanks for digging up those links > I still think this is a reasonable way to go. At one point I had a > proof-of-concept conversion of some of the ref code, but I don't think I > have it any more. Ah, that's interesting - the ref transaction functions already take a struct strbuf to populate with an error message so maybe that would be a simple place to start with a conversion to an error struct. Best Wishes Phillip