From: Benjamin Meyer Date: Sun, 21 Mar 2010 17:02:29 GMT Subject: Re: [PATCH] use -q instead of redirect to /dev/null for git update-index Message-ID: <70E4FE83-0DC9-4AF1-BA20-BE6467FC8D07@meyerhome.net> In-Reply-To: <7vy6hlvmoy.fsf@alter.siamese.dyndns.org> > The above can be said to other "/dev/null to -q" patches we saw on the > list recently. The saddest part of the story is that, the review cost > (not necessarily spent by me, but time spent by other people reviewing > patches is precious) is paid only to prevent a breakage like this patch > tries to introduce from getting accepted, without much potential reward. > Even if some of those patches turn out to be harmless, the only thing we > would have bought with the cost of reviewing is that we made sure that the > system would continue to work as before, but that is what we could have > easily done by not even looking at the patches at all. For what it is worth I got the task from the Git Janitor wiki page. https://git.wiki.kernel.org/index.php/Janitor Sorry I didn't include that in my changelog. -Benjamin Meyer