From: Алексей Шумкин <zapped@mail.ru>
Date: Wed, 05 Jan 2011 11:44:17 GMT
Subject: Re[2]: [PATCH 2/3] Fixes bug: git-svn: svn.pathnameencoding is not respected with dcommit/set-tree
Message-ID: <707440142.20110105144417@mail.ru>
In-Reply-To: <201101041818.09365.trast@student.ethz.ch>

As I already said I'm newbie in submitting/distributing patches
but I'll try :)

Tuesday, January 4, 2011, 8:18:09 PM, you wrote:

TR> Zapped wrote:
>> git-svn dcommit/set-tree fails when svn.pathnameencoding is set for native OS encoding (e.g. cp1251 for Windows) though git-svn fetch/clone works well

TR> I'll let Eric judge whether loading the encoding here is the right
TR> fix, but here too the commit message states only what is broken, not
TR> why you fixed it that way.  Can you elaborate a bit?

TR> Also, this should be easy to cover with a test case, can you make one?

>>  git-svn.perl |    1 +
>>  1 files changed, 1 insertions(+), 0 deletions(-)
>> 
>> diff --git a/git-svn.perl b/git-svn.perl
>> index 757de82..399bf4c 100755
>> --- a/git-svn.perl
>> +++ b/git-svn.perl
>> @@ -4451,6 +4451,7 @@ sub new {
>>       $self->{path_prefix} = length $self->{svn_path} ?
>>                              "$self->{svn_path}/" : '';
>>       $self->{config} = $opts->{config};
>> +     $self->{pathnameencoding} = Git::config('svn.pathnameencoding');
>>       return $self;
>>  }
>>  
>> 



-- 
С уважением,
 Алексей Шумкин                            mailto:zapped@mail.ru