From: Wincent Colaiuta <win@wincent.com>
Date: Mon, 10 Dec 2007 07:32:43 GMT
Subject: Re: [PATCH] Interactive editor tests for commit-msg hook
Message-ID: <704CE0C4-FD30-424B-86DF-2625E39707B7@wincent.com>
In-Reply-To: <7vwsrnmczu.fsf@gitster.siamese.dyndns.org>

El 10/12/2007, a las 4:42, Junio C Hamano escribió:

>> +# set up fake editor for interactive editing
>> +cat > fake-editor <<'EOF'
>> +#!/bin/sh
>> +cp FAKE_MSG "$1"
>> +exit 0
>> +EOF
>> +chmod +x fake-editor
>> +FAKE_EDITOR="$(pwd)/fake-editor"
>> +export FAKE_EDITOR
>
> Hmm.  Why "export"?

Because I'd seen it in other tests (eg. t3404-rebase-interactive.sh),  
so I just copied the style. If it's not necessary though we can lose it.

> I initially was going to say "this is just a style thing", but I  
> really
> want our tests to read uniformly like this:

Ok, fixed up version will follow in a couple of minutes.

Cheers,
Wincent