From: Agatha Isabelle <code@agatha.dev>
Date: Thu, 09 Oct 2025 23:49:48 GMT
Subject: Re: [PATCH] [Outreachy] patch-ids: fix const correctness
Message-ID: <6n5vp3vkmk6gota27baejwu2mkuqppy65efsiimvjqnhjjqecz@uud5yaetl5l2>
In-Reply-To: <20251009215737.1196464-1-okhuomonajayi54@gmail.com>

Hello!

Nice patch!

One detail I would add, though, I think the correct way to submit a v2
patch is to prefix it with the `[PATCH v2]` prefix.

See:
https://git-scm.com/docs/SubmittingPatches
https://git-scm.com/docs/MyFirstContribution

On Thu, Oct 09, 2025 at 10:57:20PM +0100, Okhuomon Ajayi wrote:
> Fix const correctness warning in patch_id_neq() in patch-ids.c.
> 

Before the changes, I think there must be the `Signed-off-by:` line.

> Changes in v2:
> - Removed NEEDSWORK comment

And this part of the message, the changelog, I think it's supposed to be
in the email message but not as part of the commit log.

> ---
>  patch-ids.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/patch-ids.c b/patch-ids.c
> index a5683b462c..b6b808332f 100644
> --- a/patch-ids.c
> +++ b/patch-ids.c
> @@ -41,8 +41,8 @@ static int patch_id_neq(const void *cmpfn_data,
>  			const struct hashmap_entry *entry_or_key,
>  			const void *keydata UNUSED)
>  {
> -	/* NEEDSWORK: const correctness? */
> -	struct diff_options *opt = (void *)cmpfn_data;
> +	
> +	const struct diff_options *opt = (void *)cmpfn_data;
>  	struct patch_id *a, *b;
>  
>  	a = container_of(eptr, struct patch_id, ent);
> -- 
> 2.43.0
> 

I hope it was helpful.

Best,
Ágatha Isabelle